You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Ernesto Reinaldo Barreiro <re...@gmail.com> on 2023/04/21 04:18:15 UTC
using fileupload2
Hi,
I was looking into the Form's code for wicket 10.x and I just noticed that
by using file fileupload2 we will lose the ability to distinguish between
one file that is too big and the whole request is too big.
https://issues.apache.org/jira/browse/WICKET-7051
Besides that I would like to ask why do we need to jump to fileupload2? Is
it because of the "Jakarta thing"?
--
Regards - Ernesto Reinaldo Barreiro
Re: using fileupload2
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
https://github.com/apache/commons-fileupload/pull/216
On Sat, Apr 22, 2023 at 7:58 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:
> https://issues.apache.org/jira/browse/FILEUPLOAD-350
>
> On Sat, Apr 22, 2023 at 7:43 AM Ernesto Reinaldo Barreiro <
> reiern70@gmail.com> wrote:
>
>> Hi,
>>
>> Many thanks for the explanation. I think problem is in our court as
>> fileupload2 seems to still detect total size problem
>>
>> https://github.com/apache/wicket/pull/586
>>
>>
>>
>> On Fri, Apr 21, 2023 at 2:00 PM Martin Grigorov <mg...@apache.org>
>> wrote:
>>
>>> On Fri, Apr 21, 2023 at 7:18 AM Ernesto Reinaldo Barreiro <
>>> reiern70@gmail.com> wrote:
>>>
>>> > Hi,
>>> >
>>> > I was looking into the Form's code for wicket 10.x and I just noticed
>>> that
>>> > by using file fileupload2 we will lose the ability to distinguish
>>> between
>>> > one file that is too big and the whole request is too big.
>>> >
>>>
>>> I guess the problem is from
>>>
>>> https://github.com/apache/wicket/commit/8f8951b64db7006b131f7acfc8ad8f32bc6dca8a
>>> Gary Gregory refactored commons-fileupload2 recently and removed the
>>> logic
>>> -
>>>
>>> https://github.com/apache/commons-fileupload/commit/355d264689c8430a4ee7bd8dfd36fcf8d9459bcf
>>> The best is to file an issue to commons-fileupload -
>>> https://issues.apache.org/jira/projects/FILEUPLOAD
>>>
>>>
>>> >
>>> > https://issues.apache.org/jira/browse/WICKET-7051
>>> >
>>> > Besides that I would like to ask why do we need to jump to
>>> fileupload2? Is
>>> > it because of the "Jakarta thing"?
>>> >
>>>
>>> Yes!
>>>
>>>
>>>
>>> >
>>> > --
>>> > Regards - Ernesto Reinaldo Barreiro
>>> >
>>>
>>
>>
>> --
>> Regards - Ernesto Reinaldo Barreiro
>>
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
--
Regards - Ernesto Reinaldo Barreiro
Re: using fileupload2
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
https://issues.apache.org/jira/browse/FILEUPLOAD-350
On Sat, Apr 22, 2023 at 7:43 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:
> Hi,
>
> Many thanks for the explanation. I think problem is in our court as
> fileupload2 seems to still detect total size problem
>
> https://github.com/apache/wicket/pull/586
>
>
>
> On Fri, Apr 21, 2023 at 2:00 PM Martin Grigorov <mg...@apache.org>
> wrote:
>
>> On Fri, Apr 21, 2023 at 7:18 AM Ernesto Reinaldo Barreiro <
>> reiern70@gmail.com> wrote:
>>
>> > Hi,
>> >
>> > I was looking into the Form's code for wicket 10.x and I just noticed
>> that
>> > by using file fileupload2 we will lose the ability to distinguish
>> between
>> > one file that is too big and the whole request is too big.
>> >
>>
>> I guess the problem is from
>>
>> https://github.com/apache/wicket/commit/8f8951b64db7006b131f7acfc8ad8f32bc6dca8a
>> Gary Gregory refactored commons-fileupload2 recently and removed the logic
>> -
>>
>> https://github.com/apache/commons-fileupload/commit/355d264689c8430a4ee7bd8dfd36fcf8d9459bcf
>> The best is to file an issue to commons-fileupload -
>> https://issues.apache.org/jira/projects/FILEUPLOAD
>>
>>
>> >
>> > https://issues.apache.org/jira/browse/WICKET-7051
>> >
>> > Besides that I would like to ask why do we need to jump to fileupload2?
>> Is
>> > it because of the "Jakarta thing"?
>> >
>>
>> Yes!
>>
>>
>>
>> >
>> > --
>> > Regards - Ernesto Reinaldo Barreiro
>> >
>>
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
--
Regards - Ernesto Reinaldo Barreiro
Re: using fileupload2
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
Hi,
Many thanks for the explanation. I think problem is in our court as
fileupload2 seems to still detect total size problem
https://github.com/apache/wicket/pull/586
On Fri, Apr 21, 2023 at 2:00 PM Martin Grigorov <mg...@apache.org>
wrote:
> On Fri, Apr 21, 2023 at 7:18 AM Ernesto Reinaldo Barreiro <
> reiern70@gmail.com> wrote:
>
> > Hi,
> >
> > I was looking into the Form's code for wicket 10.x and I just noticed
> that
> > by using file fileupload2 we will lose the ability to distinguish between
> > one file that is too big and the whole request is too big.
> >
>
> I guess the problem is from
>
> https://github.com/apache/wicket/commit/8f8951b64db7006b131f7acfc8ad8f32bc6dca8a
> Gary Gregory refactored commons-fileupload2 recently and removed the logic
> -
>
> https://github.com/apache/commons-fileupload/commit/355d264689c8430a4ee7bd8dfd36fcf8d9459bcf
> The best is to file an issue to commons-fileupload -
> https://issues.apache.org/jira/projects/FILEUPLOAD
>
>
> >
> > https://issues.apache.org/jira/browse/WICKET-7051
> >
> > Besides that I would like to ask why do we need to jump to fileupload2?
> Is
> > it because of the "Jakarta thing"?
> >
>
> Yes!
>
>
>
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>
--
Regards - Ernesto Reinaldo Barreiro
Re: using fileupload2
Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Apr 21, 2023 at 7:18 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:
> Hi,
>
> I was looking into the Form's code for wicket 10.x and I just noticed that
> by using file fileupload2 we will lose the ability to distinguish between
> one file that is too big and the whole request is too big.
>
I guess the problem is from
https://github.com/apache/wicket/commit/8f8951b64db7006b131f7acfc8ad8f32bc6dca8a
Gary Gregory refactored commons-fileupload2 recently and removed the logic
-
https://github.com/apache/commons-fileupload/commit/355d264689c8430a4ee7bd8dfd36fcf8d9459bcf
The best is to file an issue to commons-fileupload -
https://issues.apache.org/jira/projects/FILEUPLOAD
>
> https://issues.apache.org/jira/browse/WICKET-7051
>
> Besides that I would like to ask why do we need to jump to fileupload2? Is
> it because of the "Jakarta thing"?
>
Yes!
>
> --
> Regards - Ernesto Reinaldo Barreiro
>