You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/07/06 14:36:23 UTC
[GitHub] tajo pull request: [TAJO-911] Refactoring MySQL/MariaDB Catalog St...
GitHub user charsyam opened a pull request:
https://github.com/apache/tajo/pull/59
[TAJO-911] Refactoring MySQL/MariaDB Catalog Store
MySQLStore and MariaDBStore are almost same.
so it is better to extract parent class for them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/charsyam/tajo TAJO-911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit dac64ac5ea009b2df37084bd54d2176c47f61d21
Author: clark.kang <cl...@kakao.com>
Date: 2014-07-06T12:35:05Z
[TAJO-911] Refactoring MySQL/MariaDB Catalog Store
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: [TAJO-911] Refactoring MySQL/MariaDB Catalog St...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/59#issuecomment-48141635
The patch looks good to me. It's just a question. Did you test it on a local or real cluster? This is because I'm concerned with the difficulty of integrated unit tests of catalog drivers like MySQL or MariaDB.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: [TAJO-911] Refactoring MySQL/MariaDB Catalog St...
Posted by charsyam <gi...@git.apache.org>.
Github user charsyam commented on the pull request:
https://github.com/apache/tajo/pull/59#issuecomment-48141804
@hyunsik I just test it in my local system.
I just changed TestCatalog.java to use MariaDB Driver.
ant it made Tables well.
after test. TestCatalog made below tables;
MariaDB [tajo]> show tables;
+-------------------+
| Tables_in_tajo |
+-------------------+
| COLUMNS |
| DATABASES_ |
| INDEXES |
| META |
| OPTIONS |
| PARTITIONS |
| PARTITION_METHODS |
| STATS |
| TABLES |
| TABLESPACES |
+-------------------+
MariaDB [tajo]> select * from DATABASES_;
+-------+---------+----------+
| DB_ID | DB_NAME | SPACE_ID |
+-------+---------+----------+
| 1 | default | 1 |
| 20 | tmpdb3 | 1 |
| 21 | tmpdb4 | 1 |
+-------+---------+----------+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: [TAJO-911] Refactoring MySQL/MariaDB Catalog St...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/59
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: [TAJO-911] Refactoring MySQL/MariaDB Catalog St...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/59#issuecomment-48268446
+1
the patch looks good to me. Thank you for sharing your test result. I've also tested TestCatalog agsinst MySQL. I'll commit it shortly.
This documentation may be useful to you.
https://cwiki.apache.org/confluence/display/TAJO/Unit+Tests
Aside from this issue, I'm concerning with integration test of mysql/mariadb catalog driver. For example, we can do 'mvn clean install' with an external mysql as a catalog store. I'll discuss it more in another Jira issue when we needed.
Aside from this issue, I'm concerning with
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---