You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/05/11 23:07:14 UTC

[Impala-ASF-CR] PROTOTYPE IMPALA-11260: Add add-opens to JAVA TOOL OPTIONS on startup

Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19845

to look at the new patch set (#4).

Change subject: PROTOTYPE IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup
......................................................................

PROTOTYPE IMPALA-11260: Add add-opens to JAVA_TOOL_OPTIONS on startup

During Impala startup, Before starting the JVM (by calling libhdfs),
adds add-opens calls to JAVA_TOOL_OPTIONS to ensure Ehcache has access
to non-public members so it can accurately calculate object size.

This effectively circumvents new security precautions in Java 9+.

Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8
---
M be/src/common/init.cc
M bin/start-impala-cluster.py
M docker/daemon_entrypoint.sh
3 files changed, 52 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/45/19845/4
-- 
To view, visit http://gerrit.cloudera.org:8080/19845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I47a6533b2aa94593d9348e8e3606633f06a111e8
Gerrit-Change-Number: 19845
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>