You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@milagro.apache.org by "kealan (via GitHub)" <gi...@apache.org> on 2023/03/27 10:38:27 UTC
[GitHub] [incubator-milagro-crypto-js] kealan opened a new pull request, #32: Update README to make master the default branch
kealan opened a new pull request, #32:
URL: https://github.com/apache/incubator-milagro-crypto-js/pull/32
Update README to make master the default branch.
Remove travis from build. Remove badges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-js] ruphy commented on a diff in pull request #32: Update README to make master the default branch
Posted by "ruphy (via GitHub)" <gi...@apache.org>.
ruphy commented on code in PR #32:
URL: https://github.com/apache/incubator-milagro-crypto-js/pull/32#discussion_r1156997613
##########
README.md:
##########
@@ -19,17 +19,8 @@
# MCJS - *Milagro Crypto JavaScript*
-[](https://github.com/apache/incubator-milagro-crypto-js/tree/master)
-[](https://travis-ci.org/apache/incubator-milagro-crypto-js?branch=master)
-[](https://coveralls.io/github/apache/incubator-milagro-crypto-js?branch=master)
-
-[](https://github.com/apache/incubator-milagro-crypto-js/tree/develop)
-[](https://travis-ci.org/apache/incubator-milagro-crypto-js?branch=develop)
-[](https://coveralls.io/github/apache/incubator-milagro-crypto-js?branch=develop)
-
-
* **category**: Library
-* **copyright**: 2019 The Apache Software Foundation
+* **copyright**: 2023 The Apache Software Foundation
Review Comment:
```suggestion
* **copyright**: The Apache Software Foundation
```
it's no longer considered good practice to update copyright year in this manner, open source projects are recently either stripping this info entirely or leaving the year of file creation in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org
[GitHub] [incubator-milagro-crypto-js] kealan merged pull request #32: Update README to make master the default branch
Posted by "kealan (via GitHub)" <gi...@apache.org>.
kealan merged PR #32:
URL: https://github.com/apache/incubator-milagro-crypto-js/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@milagro.apache.org
For additional commands, e-mail: issues-help@milagro.apache.org