You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/04/17 11:53:19 UTC
[GitHub] [maven-shared-utils] elharo opened a new pull request #84: revert #73
elharo opened a new pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84
@slachiewicz Please check jenkins before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] MartinKanters commented on a change in pull request #84: revert #73
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84#discussion_r615287734
##########
File path: pom.xml
##########
@@ -72,6 +72,12 @@
<artifactId>jansi</artifactId>
<version>2.2.0</version>
<optional>true</optional>
+ </dependency>
+ <dependency>
Review comment:
```suggestion
<dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] pzygielo commented on pull request #84: revert #73
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84#issuecomment-821960295
@slachiewicz - with 1461e4d committed - please close this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] pzygielo commented on pull request #84: revert #73
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84#issuecomment-821811489
Should it be #78 instead of #73 referenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] MartinKanters commented on pull request #84: revert #73
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84#issuecomment-821865068
Apart from the indenting suggestion, everything looks fine.
- Jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-utils/job/rb/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] slachiewicz closed pull request #84: revert #73
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #84:
URL: https://github.com/apache/maven-shared-utils/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org