You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/01/10 19:00:25 UTC
Review Request 55387: AMBARI-19446: Able to skip writing
configuration files
when the config type doesn't exist in the command JSON file
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
Bugs: AMBARI-19446
https://issues.apache.org/jira/browse/AMBARI-19446
Repository: ambari
Description
-------
Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ea21c49
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
Diff: https://reviews.apache.org/r/55387/diff/
Testing
-------
existing unit test
build Ambari RPMS off trunk code and install a cluster.
Thanks,
Di Li
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161100
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On Jan. 10, 2017, 7 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 7 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ea21c49
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161594
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 3:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/
-----------------------------------------------------------
(Updated Jan. 13, 2017, 3:44 p.m.)
Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
Bugs: AMBARI-19446
https://issues.apache.org/jira/browse/AMBARI-19446
Repository: ambari
Description
-------
Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
Diff: https://reviews.apache.org/r/55387/diff/
Testing
-------
existing unit test
build Ambari RPMS off trunk code and install a cluster.
Thanks,
Di Li
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> > -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
> >
> > I want to understand the root cause first.
>
> Di Li wrote:
> hi Alejandro,
>
> This JIRA is to deal with third party stacks that are lack of config type as well as properties in existing configurations.
>
> The logic should not impact HDP. It helps to third party stacks to run without having to ship empty config xml files (to satisfy the Python scripts) or adding unnecessary properties to existing configuration xml files.
Are you saying that in a service like Sqoop that sqoop-site is optional? Samem goes for the other config types in Hive and Knox.
If so, we need a better way of indicating optional configs.
I don't want relaxing constraints to introduce bugs if configs that need to be present are not there.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 3:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> > -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
> >
> > I want to understand the root cause first.
>
> Di Li wrote:
> hi Alejandro,
>
> This JIRA is to deal with third party stacks that are lack of config type as well as properties in existing configurations.
>
> The logic should not impact HDP. It helps to third party stacks to run without having to ship empty config xml files (to satisfy the Python scripts) or adding unnecessary properties to existing configuration xml files.
>
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
>
> I don't want relaxing constraints to introduce bugs if configs that need to be present are not there.
I'm ok with relaxing constraints, I just want to understand the reason why Sqoop, Hive, and Knox would not have those config types.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 3:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Di Li <di...@ca.ibm.com>.
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> > -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
> >
> > I want to understand the root cause first.
hi Alejandro,
This JIRA is to deal with third party stacks that are lack of config type as well as properties in existing configurations.
The logic should not impact HDP. It helps to third party stacks to run without having to ship empty config xml files (to satisfy the Python scripts) or adding unnecessary properties to existing configuration xml files.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
On Jan. 10, 2017, 7 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 7 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ea21c49
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> > -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
> >
> > I want to understand the root cause first.
>
> Di Li wrote:
> hi Alejandro,
>
> This JIRA is to deal with third party stacks that are lack of config type as well as properties in existing configurations.
>
> The logic should not impact HDP. It helps to third party stacks to run without having to ship empty config xml files (to satisfy the Python scripts) or adding unnecessary properties to existing configuration xml files.
>
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
>
> I don't want relaxing constraints to introduce bugs if configs that need to be present are not there.
>
> Alejandro Fernandez wrote:
> I'm ok with relaxing constraints, I just want to understand the reason why Sqoop, Hive, and Knox would not have those config types.
>
> Di Li wrote:
> Hi Alejandro,
>
> For stacks that I work on (third party, not HDP stacks), Sqoop only needs sqoop-env.xml - as Sqoop build I am using doesn't require sqoop-site.xml. Similarly, the Hive and Knox builds I am using do not have the same sets of configuration xml files or the properties as HDP.
>
> My current work requires me to update services in my stack to extend common services. This change is OK when I run express upgrade. But when I run a downgrade, the addtional config type and properties common services Python scripts require causes downgrade to fail as the actual configurations during the downgrade time is from my old release/stack (lack of sqoop-site.xml, for example)
>
> So my thought was to update common services to skip the ones that cause my downgrade to fail. So that common services will not force me to have configurations that I don't need.
k, thank you for the explanation.
In the future, it would be good to for the stacks to define which config types are optional/required.
Your change is ok in common-services since it needs to support all stacks.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 3:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Di Li <di...@ca.ibm.com>.
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, line 246
> > <https://reviews.apache.org/r/55387/diff/1/?file=1601399#file1601399line246>
> >
> > -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
> > Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
> >
> > I want to understand the root cause first.
>
> Di Li wrote:
> hi Alejandro,
>
> This JIRA is to deal with third party stacks that are lack of config type as well as properties in existing configurations.
>
> The logic should not impact HDP. It helps to third party stacks to run without having to ship empty config xml files (to satisfy the Python scripts) or adding unnecessary properties to existing configuration xml files.
>
> Alejandro Fernandez wrote:
> Are you saying that in a service like Sqoop that sqoop-site is optional? Samem goes for the other config types in Hive and Knox.
> If so, we need a better way of indicating optional configs.
>
> I don't want relaxing constraints to introduce bugs if configs that need to be present are not there.
>
> Alejandro Fernandez wrote:
> I'm ok with relaxing constraints, I just want to understand the reason why Sqoop, Hive, and Knox would not have those config types.
Hi Alejandro,
For stacks that I work on (third party, not HDP stacks), Sqoop only needs sqoop-env.xml - as Sqoop build I am using doesn't require sqoop-site.xml. Similarly, the Hive and Knox builds I am using do not have the same sets of configuration xml files or the properties as HDP.
My current work requires me to update services in my stack to extend common services. This change is OK when I run express upgrade. But when I run a downgrade, the addtional config type and properties common services Python scripts require causes downgrade to fail as the actual configurations during the downgrade time is from my old release/stack (lack of sqoop-site.xml, for example)
So my thought was to update common services to skip the ones that cause my downgrade to fail. So that common services will not force me to have configurations that I don't need.
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
On Jan. 13, 2017, 3:44 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 3:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 7911058
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 55387: AMBARI-19446: Able to skip writing
configuration
files when the config type doesn't exist in the command JSON file
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55387/#review161099
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py (line 246)
<https://reviews.apache.org/r/55387/#comment232336>
-1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug.
Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology?
I want to understand the root cause first.
- Alejandro Fernandez
On Jan. 10, 2017, 7 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55387/
> -----------------------------------------------------------
>
> (Updated Jan. 10, 2017, 7 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
>
>
> Bugs: AMBARI-19446
> https://issues.apache.org/jira/browse/AMBARI-19446
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Able to skip writing configuration files when the config type doesn't exist in the command JSON file.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/get_config.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ea21c49
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py cce9c5f
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py 8416e98
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py 53a3316
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py d005cbe
>
> Diff: https://reviews.apache.org/r/55387/diff/
>
>
> Testing
> -------
>
> existing unit test
> build Ambari RPMS off trunk code and install a cluster.
>
>
> Thanks,
>
> Di Li
>
>