You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by chaithu14 <gi...@git.apache.org> on 2016/07/26 12:11:45 UTC
[GitHub] apex-core pull request #362: APEXCORE-494 Fixed the dynamic partition issue ...
GitHub user chaithu14 opened a pull request:
https://github.com/apache/apex-core/pull/362
APEXCORE-494 Fixed the dynamic partition issue in case of initial partition size is 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chaithu14/incubator-apex-core APEXCORE-494-DPartIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/apex-core/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit 3372ad70b63c7086483e6815315089e98703f989
Author: Chaitanya <ch...@datatorrent.com>
Date: 2016-07-26T12:09:52Z
APEXCORE-494 Fixed the dynamic partition issue in case of initial partition size is 1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core issue #362: APEXCORE-494 Fixed the dynamic partition issue in case...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the issue:
https://github.com/apache/apex-core/pull/362
See #365 for correct fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #362: APEXCORE-494 Fixed the dynamic partition issue ...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/362#discussion_r72893138
--- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
@@ -962,8 +963,11 @@ private void redoPartitions(PMapping currentMapping, String note)
mainPC.operatorIdToPartition.put(p.getId(), newPartition);
}
+ // Get the deepest down stream mapping
+ PMapping downStreamMapping = currentMapping;
--- End diff --
What means "deepest"? There could be multiple such mappings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #362: APEXCORE-494 Fixed the dynamic partition issue ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/apex-core/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core issue #362: APEXCORE-494 Fixed the dynamic partition issue in case...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the issue:
https://github.com/apache/apex-core/pull/362
Unifiers are handled in StreamMapping, any reason why this shouldn't be covered there? It may help to discuss this first before writing the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core issue #362: APEXCORE-494 Fixed the dynamic partition issue in case...
Posted by chaithu14 <gi...@git.apache.org>.
Github user chaithu14 commented on the issue:
https://github.com/apache/apex-core/pull/362
This fix is related to dynamic partitioning and logic related to re-partitioning is in redoPartitions().
Thanks Thomas, its a good suggestion. I will re-look in to it and will discuss with you before fixing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core issue #362: APEXCORE-494 Fixed the dynamic partition issue in case...
Posted by chaithu14 <gi...@git.apache.org>.
Github user chaithu14 commented on the issue:
https://github.com/apache/apex-core/pull/362
@vrozov Please review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] apex-core pull request #362: APEXCORE-494 Fixed the dynamic partition issue ...
Posted by chaithu14 <gi...@git.apache.org>.
Github user chaithu14 commented on a diff in the pull request:
https://github.com/apache/apex-core/pull/362#discussion_r72926469
--- Diff: engine/src/main/java/com/datatorrent/stram/plan/physical/PhysicalPlan.java ---
@@ -962,8 +963,11 @@ private void redoPartitions(PMapping currentMapping, String note)
mainPC.operatorIdToPartition.put(p.getId(), newPartition);
}
+ // Get the deepest down stream mapping
+ PMapping downStreamMapping = currentMapping;
--- End diff --
If partitionContexts linked hashmap exists then downStreamMapping be the last element of hasmap otherwise downStreamMapping be the currentMapping.
Lets say, the physical dag before repartition as below :
A1 -> B1 -> C1 -> D1 and parallel partition between A -> B and B -> C.
If A is repartitioned to 3 then
downStreamMapping would be the Operator C's mapping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---