[jira] [Updated] (HADOOP-13158) S3AFileSystem#toString might throw NullPointerException due to null cannedACL.

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-13158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HADOOP-13158:
-----------------------------------
    Attachment: HADOOP-13158.001.patch

I missed this in my code review of HADOOP-13028.  I saw this happen in a test run recently.  Here is a patch to fix it.  I reviewed the whole {{toString}} method for similar bugs, and {{cannedACL}} is the only problem.  [~stevel@apache.org], would you please review?

> S3AFileSystem#toString might throw NullPointerException due to null cannedACL.
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-13158
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13158
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13158.001.patch
>
>
> The {{cannedACL}} field of {{S3AFileSystem}} can be {{null}}.  The {{toString}} implementation has an unguarded call to {{cannedACL.toString()}}, so there is a risk of {{NullPointerException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org