You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/04 19:25:13 UTC
[kudu-CR] installation.adoc: add openssl requirement for macOS
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4952
to review the following change.
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
installation.adoc: add openssl requirement for macOS
Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
---
M docs/installation.adoc
1 file changed, 16 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/4952/1
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] installation.adoc: add openssl requirement for macOS
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4952
to look at the new patch set (#2).
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
installation.adoc: add openssl requirement for macOS
Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
---
M docs/installation.adoc
1 file changed, 18 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/4952/2
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] installation.adoc: add openssl requirement for macOS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] installation.adoc: add openssl requirement for macOS
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4952/1/docs/installation.adoc
File docs/installation.adoc:
Line 512: [[osx_from_source]]
> This should be updated, or removed entirely if there's no link to it elsewh
I'm going to leave this, in case there are outstanding links.
Line 579: .OSX Build Script
> macOS Build Script?
Done
PS1, Line 581: OSX
> macOS
Done
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] installation.adoc: add openssl requirement for macOS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
Patch Set 1:
(3 comments)
We also need to doc the openssl requirement on Linux. Do you want to do that here, or later?
http://gerrit.cloudera.org:8080/#/c/4952/1/docs/installation.adoc
File docs/installation.adoc:
Line 512: [[osx_from_source]]
This should be updated, or removed entirely if there's no link to it elsewhere.
Line 579: .OSX Build Script
macOS Build Script?
PS1, Line 581: OSX
macOS
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] installation.adoc: add openssl requirement for macOS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: installation.adoc: add openssl requirement for macOS
......................................................................
installation.adoc: add openssl requirement for macOS
Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Reviewed-on: http://gerrit.cloudera.org:8080/4952
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M docs/installation.adoc
1 file changed, 18 insertions(+), 13 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4952
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f68aeecd0194da645269bb232cc0b96d6bb5cc7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins