You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/03/27 11:14:38 UTC
[PR] Add createSingletonService() to all test-infra service factories [camel]
gnodet opened a new pull request, #22294:
URL: https://github.com/apache/camel/pull/22294
## Summary
Add `createSingletonService()` to all 28 test-infra service factories that were missing it. This is a preparatory step for safe within-JVM parallel test execution (`camel.failsafe.parallel=true`).
- Each factory now provides a `SingletonXxxService` inner class, lazy-init holder, and `createSingletonService()` factory method
- Follows the established pattern from `KafkaServiceFactory`
- No behavioral change — existing `createService()` callers are unaffected
**Factories updated**: AzureStorageBlob, AzureStorageQueue, Cassandra, Consul, Docling, GooglePubSub, Hashicorp, Hazelcast, IbmMQ, Iggy, Ignite, Keycloak, McpEverything, McpEverythySse, MicroprofileLRA, Minio, Mosquitto, Nats, Openldap, Postgres, PostgresVector, RabbitMQ, Redis, Solr, TensorFlowServing, Triton, Xmpp, ZooKeeper.
**Related**: PR #22287 (instance-unique container names for cross-JVM safety)
## Follow-up
Migrate test classes from `createService()` to `createSingletonService()` where safe (tests that don't modify service-level state).
## Test plan
- [x] All 28 factories compile successfully
- [x] Formatter/import check passes
- [ ] CI build passes
- [ ] Integration tests verify singleton services work correctly
_Claude Code on behalf of Guillaume Nodet_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24387: Add createSingletonService() and migrate all tests to singletons [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-5277305950
Hi @gnodet,
I rebased the branch on latest main (only one conflict in `JmsReplyToIbmMQTest.java` — resolved by combining main's `public` removal with `createSingletonService()`).
Also created [CAMEL-24387](https://issues.apache.org/jira/browse/CAMEL-24387) to track this.
While rebasing I checked for gaps — there are **9 service factories** still missing `createSingletonService()`:
**Existed before the PR (missed):**
- `ArtemisServiceFactory`
- `AWSServiceFactory`
- `FtpServiceFactory`
- `InfinispanServiceFactory`
- `JDBCServiceFactory`
- `MessagingServiceFactory`
**Added after the PR was created:**
- `JaegerServiceFactory` (added 2026-06-02)
- `CyberArkVaultServiceFactory` (added 2026-07-25)
- `DuckDbServiceFactory` (added 2026-07-25)
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add createSingletonService() to test-infra factories and migrate tests [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-4143568587
> LGTM, but this one likely needs a full CI test to make sure it runs fine.
Yes, I'm running tests locally for each modified factory to make sure it works.
The one that don't work will have a comment:
https://github.com/apache/camel/pull/22294/changes#diff-4677c71b137d3f514242cb2407edc44042f5f8068594d75177c07522fb0de878R48
It's not completely done yet...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24387: Add createSingletonService() and migrate all tests to singletons [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-5277348606
I added `createSingletonService()` to the 3 factories that were genuinely missing it:
- **CyberArkVaultServiceFactory** (new module, added 2026-07-25)
- **DuckDbServiceFactory** (new module, added 2026-07-25)
- **JaegerServiceFactory** (new module, added 2026-06-02)
The other 6 from my earlier comment don't need it:
- **ArtemisServiceFactory** — already has per-protocol singletons (`createSingletonVMService()`, `createSingletonAMQPService()`, etc.)
- **AWSServiceFactory** — already has per-AWS-service singletons (`createSingletonS3Service()`, `createSingletonSQSService()`, etc.)
- **InfinispanServiceFactory** — already has `createSingletonInfinispanService()`
- **FtpServiceFactory** — embedded Apache MINA server, not testcontainers
- **JDBCServiceFactory** — remote-only, no local container to share
- **MessagingServiceFactory** — remote-only, parameterized local constructor
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24387: Add createSingletonService() and migrate all tests to singletons [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-5277947124
⏺ The CI failure is not related to the singleton changes. Here's what happened:
- JDK 25 build: Failed due to camel-paho-mqtt5 integration test failure (failsafe reports). This is a flaky/infrastructure test issue with the Paho MQTT 5 component — not a module touched by this PR.
- JDK 17 build: Was cancelled (likely because the JDK 25 build failed first and the workflow cancelled remaining jobs).
The PR's changes (test-infra singletons) compiled and ran fine — the failure is in an unrelated component (camel-paho-mqtt5) that was included in the CI build matrix but wasn't modified by this PR.
This looks like a known flaky test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add createSingletonService() to test-infra factories and migrate tests [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-4143489613
LGTM, but this one likely needs a full CI test to make sure it runs fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add createSingletonService() to all test-infra service factories [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-4141878823
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make container names unique and migrate all tests to singletons [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22294:
URL: https://github.com/apache/camel/pull/22294#issuecomment-4353119173
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-ai/camel-chatscript`
- `components/camel-ai/camel-docling`
- `components/camel-ai/camel-kserve`
- `components/camel-ai/camel-langchain4j-agent`
- `components/camel-ai/camel-openai`
- `components/camel-ai/camel-tensorflow-serving`
- `components/camel-arangodb`
- `components/camel-azure/camel-azure-storage-blob`
- `components/camel-azure/camel-azure-storage-datalake`
- `components/camel-azure/camel-azure-storage-queue`
- `components/camel-consul`
- `components/camel-google/camel-google-pubsub`
- `components/camel-hashicorp-vault`
- `components/camel-hazelcast`
- `components/camel-iggy`
- `components/camel-jms`
- `components/camel-kafka`
- `components/camel-keycloak`
- `components/camel-ldif`
- `components/camel-minio`
- `components/camel-mongodb-gridfs`
- `components/camel-nats`
- `components/camel-paho-mqtt5`
- `components/camel-pqc`
- `components/camel-redis`
- `components/camel-solr`
- `components/camel-spring-parent/camel-spring-ai/camel-spring-ai-chat`
- `components/camel-spring-parent/camel-spring-rabbitmq`
- `components/camel-spring-parent/camel-spring-redis`
- `components/camel-xmpp`
- `components/camel-zookeeper-master`
- `components/camel-zookeeper`
- `dsl/camel-jbang/camel-jbang-it`
- `test-infra/camel-test-infra-azure-storage-blob`
- `test-infra/camel-test-infra-azure-storage-datalake`
- `test-infra/camel-test-infra-azure-storage-queue`
- `test-infra/camel-test-infra-cassandra`
- `test-infra/camel-test-infra-chatscript`
- `test-infra/camel-test-infra-cli`
- `test-infra/camel-test-infra-common`
- `test-infra/camel-test-infra-consul`
- `test-infra/camel-test-infra-docling`
- `test-infra/camel-test-infra-google-pubsub`
- `test-infra/camel-test-infra-hashicorp-vault`
- `test-infra/camel-test-infra-hazelcast`
- `test-infra/camel-test-infra-ibmmq`
- `test-infra/camel-test-infra-iggy`
- `test-infra/camel-test-infra-ignite`
- `test-infra/camel-test-infra-keycloak`
- `test-infra/camel-test-infra-mcp-everything`
- `test-infra/camel-test-infra-microprofile-lra`
- `test-infra/camel-test-infra-minio`
- `test-infra/camel-test-infra-mosquitto`
- `test-infra/camel-test-infra-nats`
- `test-infra/camel-test-infra-openldap`
- `test-infra/camel-test-infra-postgres`
- `test-infra/camel-test-infra-rabbitmq`
- `test-infra/camel-test-infra-redis`
- `test-infra/camel-test-infra-solr`
- `test-infra/camel-test-infra-tensorflow-serving`
- `test-infra/camel-test-infra-triton`
- `test-infra/camel-test-infra-xmpp`
- `test-infra/camel-test-infra-zookeeper`
> :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25168824014)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24387: Add createSingletonService() and migrate all tests to singletons [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #22294:
URL: https://github.com/apache/camel/pull/22294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org