You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Vitaly Baranovsky (JIRA)" <je...@portals.apache.org> on 2007/10/10 16:58:50 UTC
[jira] Created: (JS2-787) Non-informative error handling in
PortalSiteManager. I've created a patch
Non-informative error handling in PortalSiteManager. I've created a patch
-------------------------------------------------------------------------
Key: JS2-787
URL: https://issues.apache.org/jira/browse/JS2-787
Project: Jetspeed 2
Issue Type: Improvement
Components: Admin Portlets
Affects Versions: 2.1.3
Reporter: Vitaly Baranovsky
I think, it is a bad practice don't writing e.getMessage() when writing to log.
Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
I've created a patch to log more informative messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-787) Non-informative error handling in
PortalSiteManager. I've created a patch
Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma reassigned JS2-787:
-----------------------------
Assignee: Ate Douma
> Non-informative error handling in PortalSiteManager. I've created a patch
> -------------------------------------------------------------------------
>
> Key: JS2-787
> URL: https://issues.apache.org/jira/browse/JS2-787
> Project: Jetspeed 2
> Issue Type: Improvement
> Components: Admin Portlets
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Assignee: Ate Douma
> Attachments: patch.txt
>
>
> I think, it is a bad practice don't writing e.getMessage() when writing to log.
> Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
> I've created a patch to log more informative messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Updated: (JS2-787) Non-informative error handling in
PortalSiteManager. I've created a patch
Posted by "Vitaly Baranovsky (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vitaly Baranovsky updated JS2-787:
----------------------------------
Attachment: patch.txt
> Non-informative error handling in PortalSiteManager. I've created a patch
> -------------------------------------------------------------------------
>
> Key: JS2-787
> URL: https://issues.apache.org/jira/browse/JS2-787
> Project: Jetspeed 2
> Issue Type: Improvement
> Components: Admin Portlets
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Attachments: patch.txt
>
>
> I think, it is a bad practice don't writing e.getMessage() when writing to log.
> Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
> I've created a patch to log more informative messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Closed: (JS2-787) Non-informative error handling in
PortalSiteManager. I've created a patch
Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma closed JS2-787.
-------------------------
Resolution: Fixed
Fix Version/s: 2.2
2.1.3
Vitaly,
Your patch format was invalid. Don't know how you created it, but Eclipse could apply it.
Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.
> Non-informative error handling in PortalSiteManager. I've created a patch
> -------------------------------------------------------------------------
>
> Key: JS2-787
> URL: https://issues.apache.org/jira/browse/JS2-787
> Project: Jetspeed 2
> Issue Type: Improvement
> Components: Admin Portlets
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Assignee: Ate Douma
> Fix For: 2.1.3, 2.2
>
> Attachments: patch.txt
>
>
> I think, it is a bad practice don't writing e.getMessage() when writing to log.
> Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
> I've created a patch to log more informative messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Issue Comment Edited: (JS2-787) Non-informative error
handling in PortalSiteManager. I've created a patch
Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538379 ]
adouma edited comment on JS2-787 at 10/28/07 5:30 PM:
---------------------------------------------------------
Vitaly,
Your patch format was invalid. Don't know how you created it, but Eclipse couldn't apply it.
Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.
was (Author: adouma):
Vitaly,
Your patch format was invalid. Don't know how you created it, but Eclipse could apply it.
Anyway, I've committed a slight different solution as you proposed: by logging the exception instead.
> Non-informative error handling in PortalSiteManager. I've created a patch
> -------------------------------------------------------------------------
>
> Key: JS2-787
> URL: https://issues.apache.org/jira/browse/JS2-787
> Project: Jetspeed 2
> Issue Type: Improvement
> Components: Admin Portlets
> Affects Versions: 2.1.3
> Reporter: Vitaly Baranovsky
> Assignee: Ate Douma
> Fix For: 2.1.3, 2.2
>
> Attachments: patch.txt
>
>
> I think, it is a bad practice don't writing e.getMessage() when writing to log.
> Now Portal Site Manager writes "Failed to get root folder", but I don't know why...
> I've created a patch to log more informative messages.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org