You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Phil Sorber (JIRA)" <ji...@apache.org> on 2013/05/30 23:34:21 UTC

[jira] [Commented] (TS-1910) BACKPORT: make 3.2.x compile with Clang

    [ https://issues.apache.org/jira/browse/TS-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670749#comment-13670749 ] 

Phil Sorber commented on TS-1910:
---------------------------------

{noformat}
diff --git a/proxy/FetchSM.cc b/proxy/FetchSM.cc
index 9caf516..4db02c7 100644
--- a/proxy/FetchSM.cc
+++ b/proxy/FetchSM.cc
@@ -132,7 +132,7 @@ FetchSM::process_fetch_read(int event)
   switch (event) {
   case TS_EVENT_VCONN_READ_READY:
     bytes = resp_reader->read_avail();
-    Debug(DEBUG_TAG, "[%s] number of bytes in read ready %"PRId64"", __FUNCTION__, bytes);
+    Debug(DEBUG_TAG, "[%s] number of bytes in read ready %" PRId64, __FUNCTION__, bytes);
     while (actual_bytes_copied < bytes) {
        actual_bytes_copied = response_buffer->write(resp_reader, bytes, 0);
       resp_reader->consume(actual_bytes_copied);
@@ -154,11 +154,11 @@ FetchSM::process_fetch_read(int event)
     bytes = response_reader->read_avail();
 
     get_info_from_buffer(response_reader);
-    Debug(DEBUG_TAG, "[%s] number of bytes %"PRId64"", __FUNCTION__, bytes);
+    Debug(DEBUG_TAG, "[%s] number of bytes %" PRId64"", __FUNCTION__, bytes);
     if(client_response!=NULL)
       client_response[bytes] = '\0';
       //client_response[bytes + _headers.size()] = '\0';
{noformat}

Seems inconsistent with the trailing "" after PRId64.
                
> BACKPORT: make 3.2.x compile with Clang
> ---------------------------------------
>
>                 Key: TS-1910
>                 URL: https://issues.apache.org/jira/browse/TS-1910
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Leif Hedstrom
>             Fix For: 3.2.5
>
>         Attachments: TS-1910.diff
>
>
> There are too many bugs to clone for this, so I'm combining it all into one. The commits to backport, so far, are:
> {code}
> b216afa3
> 58205af1
> dc3f8ffa
> 81f9f418
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira