You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/06/03 18:53:16 UTC
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/773
[FLINK-2134] Close Netty channel via CloseRequest msg
The failing `SuccessAfterNetworkBuffersFailureITCase` discovered a race between sending backwards events (e.g. from sync task to iteration head task) and closing the TCP channel. The close overtook outstanding backwards task events. This change guarnatees that it is in order by sending a explicit close msg.
(I've also tried other approaches, but this struck me as the simplest solution.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/incubator-flink event-deadlock-2134
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/773.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #773
----
commit 6a4dcd0d4866ba16c432d15de25df7c161c894b7
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-06-03T16:41:40Z
[FLINK-2134] Close Netty channel via CloseRequest msg
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/773#issuecomment-108630661
Ah, it is a close from the receiver end, got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/773#issuecomment-108630865
Makes sense.
+1 to get this in!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/773
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/773#issuecomment-108795770
OK, thanks for the review. I'm merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/773#issuecomment-108627084
Can you elaborate? Why are there backwards events after the connection is closed? The iteration head should not close until the iteration terminates, in which case there should be no back events any more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2134] Close Netty channel via CloseRequ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/773#issuecomment-108628742
No, there are no backwards events *after* the channel is closed. The sync sends out the backwards events, then closes. But the close could overtake the unflushed backwards events. This lead to a deadlock, because the head was waiting on termination events, which never arrived.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---