You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/13 01:08:18 UTC
[GitHub] ZhennanQin commented on a change in pull request #13628:
Feature/mkldnn static
ZhennanQin commented on a change in pull request #13628: Feature/mkldnn static
URL: https://github.com/apache/incubator-mxnet/pull/13628#discussion_r241242177
##########
File path: Makefile
##########
@@ -132,7 +132,12 @@ ifeq ($(USE_MKLDNN), 1)
LDFLAGS += -L$(MKLROOT)/lib
endif
CFLAGS += -I$(MKLDNNROOT)/include
- LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'
+ # MKLDNN but to needs to be dynamically linked for windows as not all VS compilers support static linking
+ ifneq ($(UNAME_S), Windows)
+ LIB_DEP += $(MKLDNNROOT)/lib/libmkldnn.a
+ else
+ LDFLAGS += -L$(MKLDNNROOT)/lib -lmkldnn -Wl,-rpath,'$${ORIGIN}'
Review comment:
VS compiler doesn't know those flags. Do we support VS build with Makefile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services