[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #857: HDDS-1600. Add userName and IPAddress as part of OMRequest.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #857: HDDS-1600. Add userName and IPAddress as part of OMRequest.
URL: https://github.com/apache/hadoop/pull/857#discussion_r290054092
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
 ##########
 @@ -2406,8 +2432,10 @@ public void setBucketProperty(OmBucketArgs args)
    */
   @Override
   public void deleteBucket(String volume, String bucket) throws IOException {
-    checkAcls(ResourceType.BUCKET, StoreType.OZONE, ACLType.WRITE, volume,
-        bucket, null);
+    if (isAclEnabled) {
 
 Review comment:
   This is done to avoid object creation of UGI and InetAddress.
   Talked offline, and we agreed on this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org