You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/27 15:06:14 UTC

[GitHub] janl opened a new pull request #1246: [DISCUSS] Remove duplicate authorisation check

janl opened a new pull request #1246: [DISCUSS] Remove duplicate authorisation check
URL: https://github.com/apache/couchdb/pull/1246
 
 
   While working on #1245 I noticed `fabric:get_security()` is being called twice for each database request.
   
   I tracked it down to [`chttpd_auth_request:do_authorization_check()`](https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd_auth_request.erl#L94-L96) and [`chttpd:do_db_request()`](https://github.com/apache/couchdb/blob/master/src/chttpd/src/chttpd_db.erl#L316-L319).
   
   Removing the second one passes the test suite fine. I’d like a thorough review of this, because we might not be testing an invariant that this provides for good reason.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services