You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2022/03/15 12:50:00 UTC

[jira] [Commented] (HBASE-26847) Move ConnectionImplementation public configs to HConstants

    [ https://issues.apache.org/jira/browse/HBASE-26847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506886#comment-17506886 ] 

Duo Zhang commented on HBASE-26847:
-----------------------------------

This is a no no. HConstants is considered as anti parttern, we should not move more things into it.

> Move ConnectionImplementation public configs to HConstants
> ----------------------------------------------------------
>
>                 Key: HBASE-26847
>                 URL: https://issues.apache.org/jira/browse/HBASE-26847
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Bryan Beaudreault
>            Assignee: Bryan Beaudreault
>            Priority: Minor
>
> ConnectionImplementation has a few public static config constants, but the class itself is package-private so users cannot access them. Moving them to HConstants will make it easier for users to change these settings:
> {code:java}
> hbase.client.retries.by.server
> hbase.resolve.hostnames.on.failure {code}
> Note: AsyncConnectionImpl also separately defines the second config, so we can unify them both in HConstants.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)