[GitHub] [solr] dsmiley commented on a diff in pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

[GitBox <gi...@apache.org>]

dsmiley commented on code in PR #1012:
URL: https://github.com/apache/solr/pull/1012#discussion_r990733430


##########
solr/core/src/java/org/apache/solr/packagemanager/RepositoryManager.java:
##########
@@ -141,7 +141,7 @@ public void addKey(byte[] key, String destinationKeyFilename) throws Exception {
 
     // put the public key into package store's trusted key store and request a sync.
     String path = PackageStoreAPI.KEYS_DIR + "/" + destinationKeyFilename;
-    PackageUtils.uploadKey(key, path, Paths.get(solrHome), solrClient);
+    PackageUtils.uploadKey(key, path, Paths.get(solrHome));

Review Comment:
   @sonatype-lift ignoreall
   (because we're just refactoring)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org