You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 15:07:53 UTC

[GitHub] [arrow] vertexclique commented on a change in pull request #9261: ARROW-11141: [Rust] Add basic Miri checks to CI pipeline

vertexclique commented on a change in pull request #9261:
URL: https://github.com/apache/arrow/pull/9261#discussion_r560246006



##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,37 @@ jobs:
           cd rust
           cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
 
+  miri-checks:
+    name: Miri Checks
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        arch: [amd64]
+        rust: [stable]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+      - name: Install
+        uses: actions-rs/toolchain@v1

Review comment:
       Cool, I have changed it. Now it has started.

##########
File path: .github/workflows/rust.yml
##########
@@ -226,6 +226,37 @@ jobs:
           cd rust
           cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names
 
+  miri-checks:
+    name: Miri Checks
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        arch: [amd64]
+        rust: [stable]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cargo/registry
+            ~/.cargo/git
+            target
+          key: ${{ runner.os }}-cargo-miri-${{ hashFiles('**/Cargo.lock') }}
+      - name: Install
+        uses: actions-rs/toolchain@v1

Review comment:
       Cool, I have changed it. Now it has started. Thanks 🥳 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org