You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2024/03/25 11:46:31 UTC
[PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
ByteYue opened a new pull request, #32791:
URL: https://github.com/apache/doris/pull/32791
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019331438
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #32791:
URL: https://github.com/apache/doris/pull/32791#discussion_r1537579044
##########
cloud/test/meta_service_test.cpp:
##########
@@ -5326,6 +5326,109 @@ TEST(MetaServiceTest, DropHdfsInfoTest) {
SyncPoint::get_instance()->clear_all_call_backs();
}
+TEST(MetaServiceTest, GetObjStoreInfoTest) {
Review Comment:
warning: function 'TEST' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
TEST(MetaServiceTest, GetObjStoreInfoTest) {
^
```
<details>
<summary>Additional context</summary>
**cloud/test/meta_service_test.cpp:5328:** 101 lines including whitespace and comments (threshold 80)
```cpp
TEST(MetaServiceTest, GetObjStoreInfoTest) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Correct Storage Vault's key layout && Add basic multi vault case for regression-test && Meta Service's UT [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019698569
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Correct Storage Vault's key layout && Add basic multi vault case for regression-test && Meta Service's UT [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32791:
URL: https://github.com/apache/doris/pull/32791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019358940
TeamCity be ut coverage result:
Function Coverage: 35.26% (8737/24777)
Line Coverage: 27.05% (71543/264518)
Region Coverage: 26.29% (37118/141193)
Branch Coverage: 23.18% (18975/81874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ca1b1d2561daaaf5b205cb2041723295856482b_0ca1b1d2561daaaf5b205cb2041723295856482b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019545803
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2017976606
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Correct Storage Vault's key layout && Add basic multi vault case for regression-test && Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019710910
<details>
<summary>TPC-H: <b>Total hot run time: 39784 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 163dda6baeea8db807b0688afae44e6af448b674, data reload: false
------ Round 1 ----------------------------------
q1 17617 4762 4543 4543
q2 2114 157 154 154
q3 10579 1199 1265 1199
q4 10227 880 798 798
q5 7489 3250 3222 3222
q6 220 126 124 124
q7 1100 595 566 566
q8 9346 2161 2151 2151
q9 7780 7020 6958 6958
q10 8500 3596 3720 3596
q11 434 220 215 215
q12 428 200 201 200
q13 17782 2834 2814 2814
q14 250 211 212 211
q15 519 453 456 453
q16 514 368 368 368
q17 995 662 588 588
q18 7097 6547 6436 6436
q19 2945 1545 1619 1545
q20 553 250 245 245
q21 3827 3205 3100 3100
q22 361 298 307 298
Total cold run time: 110677 ms
Total hot run time: 39784 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4543 4483 4478 4478
q2 344 231 227 227
q3 3043 2918 2888 2888
q4 1945 1622 1608 1608
q5 5434 5461 5452 5452
q6 215 117 117 117
q7 2320 1874 1878 1874
q8 3388 3559 3557 3557
q9 8816 8827 8823 8823
q10 3924 3900 3894 3894
q11 560 441 451 441
q12 729 546 537 537
q13 16926 2858 2855 2855
q14 287 249 259 249
q15 506 465 465 465
q16 478 432 435 432
q17 1873 1579 1542 1542
q18 7568 7309 7138 7138
q19 1774 1703 1714 1703
q20 1980 1737 1704 1704
q21 4999 4782 4920 4782
q22 541 462 454 454
Total cold run time: 72193 ms
Total hot run time: 55220 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2018290594
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Correct Storage Vault's key layout && Add basic multi vault case for regression-test && Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019776346
<details>
<summary>TPC-DS: <b>Total hot run time: 181442 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 163dda6baeea8db807b0688afae44e6af448b674, data reload: false
query1 946 367 351 351
query2 6544 1937 1802 1802
query3 6707 226 221 221
query4 31496 21340 21345 21340
query5 4316 399 386 386
query6 265 180 174 174
query7 4646 294 291 291
query8 224 163 186 163
query9 9479 2304 2305 2304
query10 564 246 275 246
query11 15432 14323 14252 14252
query12 144 94 86 86
query13 1627 422 414 414
query14 9289 7847 7674 7674
query15 244 195 194 194
query16 8177 267 272 267
query17 1945 583 559 559
query18 2095 285 269 269
query19 313 153 148 148
query20 95 83 88 83
query21 204 127 138 127
query22 5019 4885 4830 4830
query23 33454 32949 32749 32749
query24 11025 2892 2849 2849
query25 607 352 357 352
query26 1192 149 156 149
query27 2657 352 360 352
query28 7282 1926 1906 1906
query29 914 624 609 609
query30 299 146 147 146
query31 970 747 726 726
query32 92 60 57 57
query33 749 259 245 245
query34 1001 474 498 474
query35 827 607 606 606
query36 1021 887 885 885
query37 126 67 64 64
query38 3520 3423 3421 3421
query39 1463 1460 1433 1433
query40 208 118 109 109
query41 47 45 47 45
query42 98 99 95 95
query43 482 446 458 446
query44 1203 744 757 744
query45 277 262 256 256
query46 1091 701 689 689
query47 1939 1830 1840 1830
query48 472 360 349 349
query49 1127 327 324 324
query50 750 369 371 369
query51 6685 6648 6630 6630
query52 97 95 88 88
query53 349 275 280 275
query54 296 223 247 223
query55 91 80 83 80
query56 229 219 219 219
query57 1221 1139 1123 1123
query58 235 199 208 199
query59 2791 2565 2537 2537
query60 254 234 234 234
query61 94 92 96 92
query62 645 456 454 454
query63 302 271 283 271
query64 5753 4082 3696 3696
query65 3093 3004 3055 3004
query66 913 390 378 378
query67 15288 14949 15227 14949
query68 5421 536 530 530
query69 599 377 366 366
query70 1203 1150 1161 1150
query71 453 264 271 264
query72 6673 2839 2674 2674
query73 709 327 327 327
query74 6829 6339 6358 6339
query75 3031 2196 2274 2196
query76 3927 885 863 863
query77 628 283 259 259
query78 10982 10079 10244 10079
query79 8021 529 535 529
query80 1989 403 405 403
query81 566 225 223 223
query82 1015 88 86 86
query83 326 154 152 152
query84 291 87 84 84
query85 1939 320 308 308
query86 486 300 278 278
query87 3677 3552 3555 3552
query88 5108 2340 2324 2324
query89 483 362 372 362
query90 1971 174 176 174
query91 168 137 135 135
query92 60 46 46 46
query93 5944 505 489 489
query94 1215 190 171 171
query95 435 323 331 323
query96 605 270 276 270
query97 2643 2506 2452 2452
query98 222 215 229 215
query99 1185 922 907 907
Total cold run time: 301804 ms
Total hot run time: 181442 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Correct Storage Vault's key layout && Add basic multi vault case for regression-test && Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019782445
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 163dda6baeea8db807b0688afae44e6af448b674 with default session variables
Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.8 seconds inserted 10000000 Rows, about 458K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2017821549
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019272465
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](case) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019624610
TeamCity be ut coverage result:
Function Coverage: 35.27% (8738/24777)
Line Coverage: 27.05% (71550/264518)
Region Coverage: 26.29% (37120/141193)
Branch Coverage: 23.18% (18978/81874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/163dda6baeea8db807b0688afae44e6af448b674_163dda6baeea8db807b0688afae44e6af448b674/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](hdfs) Add basic multi vault case for regression-test and Meta Service's UT [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32791:
URL: https://github.com/apache/doris/pull/32791#issuecomment-2019637618
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org