You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/06/02 14:12:00 UTC

Review Request 34933: Changing only 'final' flag for a config not being persisted by API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34933/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11612
    https://issues.apache.org/jira/browse/AMBARI-11612


Repository: ambari


Description
-------

Go to any enhanced config page, toggle final on any config widget and save. Note that no new version is created and broken UI shows.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ad76ffa 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 1e4e332 

Diff: https://reviews.apache.org/r/34933/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 34933: Changing only 'final' flag for a config not being persisted by API

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34933/#review86205
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Червень 2, 2015, 12:12 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34933/
> -----------------------------------------------------------
> 
> (Updated Червень 2, 2015, 12:12 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11612
>     https://issues.apache.org/jira/browse/AMBARI-11612
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Go to any enhanced config page, toggle final on any config widget and save. Note that no new version is created and broken UI shows.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java ad76ffa 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 1e4e332 
> 
> Diff: https://reviews.apache.org/r/34933/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>