You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 11:10:30 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9068: ARROW-11100: [Rust] Speed up numeric to string cast using lexical_core

jorgecarleitao commented on a change in pull request #9068:
URL: https://github.com/apache/arrow/pull/9068#discussion_r550870918



##########
File path: rust/arrow/src/util/mod.rs
##########
@@ -21,5 +21,6 @@ pub mod display;
 pub mod integration_util;
 #[cfg(feature = "prettyprint")]
 pub mod pretty;
+pub mod serialization;

Review comment:
       what do you think about making this `pub(crate)` or `pub(super)`? In general I think that we should avoid exposing public unless needed, so that it is easier to refactor without breaking public apis.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org