You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/11 20:19:37 UTC

[GitHub] [spark] gengliangwang commented on pull request #37972: [SPARK-40654][SQL] Protobuf support for Spark - from_protobuf AND to_protobuf

gengliangwang commented on PR #37972:
URL: https://github.com/apache/spark/pull/37972#issuecomment-1275227108

   @SandishKumarHN This PR LGTM overall.
   Two important follow-ups:
   * Build documentation (similar to https://spark.apache.org/docs/latest/sql-data-sources-avro.html)
   * User error classes for all the exceptions 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org