You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/06 20:54:56 UTC

[GitHub] [incubator-superset] etr2460 opened a new issue #10247: Cannot edit datasources from the Pivot Table viz

etr2460 opened a new issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247


   When the pivot table viz is selected in Explore and I click on the datasource name, I don't see the option to edit the datasource, only change it or explore it in sql lab.
   
   ### Expected results
   
   See the option to edit the datasource
   
   ### Actual results
   
   Don't see that option
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/7409244/86641458-00552f80-bf90-11ea-9267-d02cb4ec6070.png)
   
   #### How to reproduce the bug
   
   1. Open a chart in explore
   2. Change it to viz type pivot-table
   3. Click on the datasource name
   4. don't see the edit datasource option
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `master`
   
   @rusackas or @suddjian, do you think this is related to moving the pivot table controls into superset-ui? I know it happened a while ago, but I can't think of another reason for this to break, so tagging you here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] etr2460 commented on issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247#issuecomment-656183567


   Thanks @suddjian!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247#issuecomment-656505208


   Oh hit this issue too and found a solution. I'm guessing this is related to the controls refactor (?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247#issuecomment-654460227


   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud closed issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
ktmud closed issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch commented on issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247#issuecomment-656506486


   See fix here https://github.com/apache/incubator-superset/pull/10283


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] suddjian commented on issue #10247: Cannot edit datasources from the Pivot Table viz

Posted by GitBox <gi...@apache.org>.
suddjian commented on issue #10247:
URL: https://github.com/apache/incubator-superset/issues/10247#issuecomment-655732503


   I don't see anything suspicious at first glance in the control config. I can do a deeper investigation later today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org