[jira] [Commented] (HIVE-8605) HIVE-5799 breaks backward compatibility for time values in config

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184311#comment-14184311 ] 

Hive QA commented on HIVE-8605:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12677133/HIVE-8605.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6579 tests executed
*Failed tests:*
{noformat}
org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeTokenAuth
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1465/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1465/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1465/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12677133 - PreCommit-HIVE-TRUNK-Build

> HIVE-5799 breaks backward compatibility for time values in config
> -----------------------------------------------------------------
>
>                 Key: HIVE-8605
>                 URL: https://issues.apache.org/jira/browse/HIVE-8605
>             Project: Hive
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 0.14.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Blocker
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8605.patch
>
>
> It is legal for long values in the config file to have an L or for float values to have an f.  For example, the default value for hive.compactor.check.interval was 300L.  As part of HIVE-5799, many long values were converted to TimeUnit.  Attempts to read these values now throw "java.lang.IllegalArgumentException: Invalid time unit l"
> We need to change this to ignore the L or f, so that users existing config files don't break.  I propose to do this by changing HiveConf.unitFor to detect the L or f and interpret it to mean the default time unit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)