You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by ge...@apache.org on 2024/02/07 16:39:15 UTC

(solr) branch branch_9x updated: SOLR-17068: Add missing PostToolTest @SuppressSSL

This is an automated email from the ASF dual-hosted git repository.

gerlowskija pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/branch_9x by this push:
     new 096b9c73248 SOLR-17068: Add missing PostToolTest @SuppressSSL
096b9c73248 is described below

commit 096b9c732489c1d320aee8909ba3190d26c4a69b
Author: Jason Gerlowski <ge...@apache.org>
AuthorDate: Wed Feb 7 11:01:30 2024 -0500

    SOLR-17068: Add missing PostToolTest @SuppressSSL
    
    The test on 'main' was initially added with a SuppressSSL annotation,
    but it appears to have been lost at some point in the backport process.
    As a result, PostToolTest fails ~6% of the time on 9x with SSL related
    issues.
    
    We should better understand the cause of this SSL failure, as we should
    for all usages of @SuppressSSL, but for now this commit re-adds the
    annotation that was errantly dropped.
---
 solr/core/src/test/org/apache/solr/cli/PostToolTest.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/solr/core/src/test/org/apache/solr/cli/PostToolTest.java b/solr/core/src/test/org/apache/solr/cli/PostToolTest.java
index e40db69a39e..88639c7cefc 100644
--- a/solr/core/src/test/org/apache/solr/cli/PostToolTest.java
+++ b/solr/core/src/test/org/apache/solr/cli/PostToolTest.java
@@ -25,6 +25,7 @@ import java.io.FileWriter;
 import java.nio.charset.StandardCharsets;
 import java.util.Map;
 import org.apache.commons.cli.CommandLine;
+import org.apache.solr.SolrTestCaseJ4;
 import org.apache.solr.client.solrj.request.CollectionAdminRequest;
 import org.apache.solr.cloud.SolrCloudTestCase;
 import org.apache.solr.common.util.EnvUtils;
@@ -32,6 +33,7 @@ import org.apache.solr.common.util.Utils;
 import org.junit.BeforeClass;
 import org.junit.Test;
 
+@SolrTestCaseJ4.SuppressSSL
 public class PostToolTest extends SolrCloudTestCase {
 
   @BeforeClass