You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Stuart McCulloch (JIRA)" <ji...@apache.org> on 2009/01/29 18:56:59 UTC
[jira] Resolved: (FELIX-850) Wrong symbolic name computed when
groupId is a single segment string.
[ https://issues.apache.org/jira/browse/FELIX-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stuart McCulloch resolved FELIX-850.
------------------------------------
Resolution: Fixed
I've fixed this locally in trunk (see r738941) the actual patch is as follows:
Index: src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java
===================================================================
--- src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java (revision 738817)
+++ src/main/java/org/apache/maven/shared/osgi/DefaultMaven2OsgiConverter.java (working copy)
@@ -78,7 +78,7 @@
*/
public String getBundleSymbolicName( Artifact artifact )
{
- if ( ( artifact.getFile() != null ) && artifact.getFile().exists() )
+ if ( ( artifact.getFile() != null ) && artifact.getFile().isFile() )
{
Analyzer analyzer = new Analyzer();
@@ -121,7 +121,7 @@
}
int i = artifact.getGroupId().lastIndexOf( '.' );
- if ( ( i < 0 ) && ( artifact.getFile() != null ) && artifact.getFile().exists() )
+ if ( ( i < 0 ) && ( artifact.getFile() != null ) && artifact.getFile().isFile() )
{
String groupIdFromPackage = getGroupIdFromPackage( artifact.getFile() );
if ( groupIdFromPackage != null )
> Wrong symbolic name computed when groupId is a single segment string.
> ---------------------------------------------------------------------
>
> Key: FELIX-850
> URL: https://issues.apache.org/jira/browse/FELIX-850
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-1.4.3
> Reporter: Mark Derricutt
> Assignee: Stuart McCulloch
> Priority: Minor
> Fix For: maven-bundle-plugin-1.6.0
>
>
> According to the documentation, a bundles symbolic name should follow respect the following:
> - if artifactId starts with last section of groupId that portion is removed. eg. org.apache.maven:maven-core -> org.apache.maven.core
> however, when the groupId a single segment, this rule is ignored. Thus a groupId of smx3 and artifactId of smx3.testing gets a symbolic name of smx3.smx3.testing. When it should just be smx3.testing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.