You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2005/04/26 09:23:53 UTC

DO NOT REPLY [Bug 33132] - org.apache.struts.upload.MultipartRequestWrapper doesn't implement servlet 2.4 api fully

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33132>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33132





------- Additional Comments From niallp@apache.org  2005-04-26 09:23 -------
Created an attachment (id=14839)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=14839&action=view)
Patch for changes to "Core" subproject

I have fixed this in the Struts 1.2.x branch (using reflection to execute the
Servlet 2.3/2.4 methods) and am attaching a patch of proposed changes for the
current (1.3) development version for review.

Changes for 1.3 basically involve making MultipartRequestWrapper extend
HttpServletRequestWrapper which would resolve this issue and the issue in Bug
17583. One slight problem with this is that the origianl getRequest() method in
MultipartRequestWrapper returned a HttpServletRequest - but the getRequest()
method now inherited from HttpServletRequestWrapper returns a ServletRequest,
which could cause slight compatibility problems.

The reason for attaching the 1.3 changes for review, rather than committing
them directly is that I understand Martin has some changes underway for file
uploading and these changes either may not be required or may be inappropriate.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org