[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #283: Adds constructors for TDML Runner

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #283: Adds constructors for TDML Runner
URL: https://github.com/apache/incubator-daffodil/pull/283#discussion_r342826549
 
 

 ##########
 File path: daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/RunnerFactory.scala
 ##########
 @@ -98,6 +98,15 @@ class Runner private (elem: scala.xml.Elem, dir: String, file: String,
   defaultValidationDefault: String = Runner.defaultValidationDefaultDefault,
   defaultImplementationsDefault: Seq[String] = Runner.defaultImplementationsDefaultDefault) {
 
+  /*
+   * these constructors are for use by Java programs
+   */
+  def this(dir: String, file:String) =
+    this(null, dir, file)
+
+  def this(elem: scala.xml.Elem) =
+    this(elem, null, null)
+
 
 Review comment:
   Can you add some TDML unit tests that use these constructors? Also, even though this is a small change, it's probably still a good idea to create a bug and add it to the commit message so there's tracability.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services