You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by eshioji <gi...@git.apache.org> on 2015/07/11 12:51:18 UTC

[GitHub] storm pull request: [STORM-874] Add UncaughtExceptionHandler for n...

Github user eshioji commented on the pull request:

    https://github.com/apache/storm/pull/597#issuecomment-120603640
  
    If the thread is used in `ThreadPoolExecutor` (like the boss & worker thread pool currently used), `UncaughtExceptionHandler` are not invoked because `ThreadPoolExecutor` suppress uncaught exceptions coming from tasks (see e.g. http://stackoverflow.com/questions/1838923/why-is-uncaughtexceptionhandler-not-called-by-executorservice). There are workarounds but they are quite hacky.
    
    Maybe it makes more sense to consider the service unhealthy if messages are unable to be dispatched, rather than based on whether an uncaught exception was encountered?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---