You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2011/09/08 17:39:11 UTC
svn commit: r1166757 - in /tomcat/trunk/test/org/apache/catalina:
comet/TestCometProcessor.java connector/TestMaxConnections.java
session/Benchmarks.java
Author: markt
Date: Thu Sep 8 15:39:11 2011
New Revision: 1166757
URL: http://svn.apache.org/viewvc?rev=1166757&view=rev
Log:
Fix Eclipse warnings in unit tests
Modified:
tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java
tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java
Modified: tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java?rev=1166757&r1=1166756&r2=1166757&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java (original)
+++ tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java Thu Sep 8 15:39:11 2011
@@ -30,6 +30,7 @@ import javax.servlet.http.HttpSession;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import org.junit.Test;
@@ -160,6 +161,7 @@ public class TestCometProcessor extends
// Write should trigger an exception once the connector stops since the
// socket should be closed
assertNotNull(writeThread.getException());
+ assertNull(readThread.getException());
}
private boolean isCometSupported() {
Modified: tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java?rev=1166757&r1=1166756&r2=1166757&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java (original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java Thu Sep 8 15:39:11 2011
@@ -60,7 +60,7 @@ public class TestMaxConnections extends
}
assertTrue("The number of successful requests should have been 4-5, actual "+passcount,4==passcount || 5==passcount);
-
+ System.out.println("There were [" + connectfail + "] connection failures");
}
private static class ConnectThread extends Thread {
Modified: tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java?rev=1166757&r1=1166756&r2=1166757&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java (original)
+++ tomcat/trunk/test/org/apache/catalina/session/Benchmarks.java Thu Sep 8 15:39:11 2011
@@ -152,7 +152,7 @@ public class Benchmarks {
* 16 threads - ~45,600ms
*/
@Test
- public void testManagerBaseCreateSession() throws LifecycleException {
+ public void testManagerBaseCreateSession() {
doTestManagerBaseCreateSession(1, 1000000);
doTestManagerBaseCreateSession(2, 1000000);
doTestManagerBaseCreateSession(4, 1000000);
@@ -163,8 +163,8 @@ public class Benchmarks {
}
- private void doTestManagerBaseCreateSession(int threadCount, int iterCount)
- throws LifecycleException {
+ private void doTestManagerBaseCreateSession(int threadCount,
+ int iterCount) {
// Create a default session manager
StandardManager mgr = new StandardManager();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org