[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

["Avery Ching (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147919#comment-13147919 ] 

Avery Ching commented on GIRAPH-74:
-----------------------------------

Some of this I also addressed in GIRAPH-11 =).  I think combining the getter/setter behavior is a little strange.  Perhaps 

void setHalted(boolean isHalted);
boolean isHalted();

Anyone else have an opinion?

                
> GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex
> ---------------------------------------------------------------------------
>
>                 Key: GIRAPH-74
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-74
>             Project: Giraph
>          Issue Type: Bug
>          Components: graph
>    Affects Versions: 0.70.0
>            Reporter: Claudio Martella
>            Assignee: Claudio Martella
>             Fix For: 0.70.0
>
>         Attachments: GIRAPH-36-cleaup.diff
>
>
> After GIRAPH-36, in a couple of places Vertex was left instead of BasicVertex. To achieve the fix a BasicVertex was extended with a new boolean isHalted(boolean state) method that totally hides boolean halt field. I believe this unifies the voteToHalt() and isHalted() methods totally hiding the halting management of Vertices (before it was relying on the existence of boolean halt field).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira