You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/03/16 18:17:46 UTC
Review Request 66119: Added a mock sandbox garbage collector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
Added a mock sandbox garbage collector.
Diffs
-----
src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
Diff: https://reviews.apache.org/r/66119/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Greg Mann <gr...@mesosphere.io>.
> On March 20, 2018, 11:08 p.m., Greg Mann wrote:
> > src/tests/mesos.hpp
> > Lines 3130 (patched)
> > <https://reviews.apache.org/r/66119/diff/2/?file=1982500#file1982500line3130>
> >
> > Let's make note here of the default behavior provided (i.e., always returns 'true' by default).
Ignore this if you end up removing the default behavior.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/#review199476
-----------------------------------------------------------
On March 16, 2018, 6:17 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66119/
> -----------------------------------------------------------
>
> (Updated March 16, 2018, 6:17 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a mock sandbox garbage collector.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
>
>
> Diff: https://reviews.apache.org/r/66119/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/#review199476
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/mesos.hpp
Lines 3130 (patched)
<https://reviews.apache.org/r/66119/#comment279783>
Let's make note here of the default behavior provided (i.e., always returns 'true' by default).
src/tests/mesos.hpp
Lines 3138 (patched)
<https://reviews.apache.org/r/66119/#comment279923>
Not indented far enough.
- Greg Mann
On March 16, 2018, 6:17 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66119/
> -----------------------------------------------------------
>
> (Updated March 16, 2018, 6:17 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a mock sandbox garbage collector.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
>
>
> Diff: https://reviews.apache.org/r/66119/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/#review200214
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 21, 2018, 9:37 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66119/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 9:37 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a mock sandbox garbage collector.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
>
>
> Diff: https://reviews.apache.org/r/66119/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/
-----------------------------------------------------------
(Updated March 21, 2018, 2:37 p.m.)
Review request for mesos and Greg Mann.
Changes
-------
Brought back the default action as some tests depend on this.
Repository: mesos
Description
-------
Added a mock sandbox garbage collector.
Diffs (updated)
-----
src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
Diff: https://reviews.apache.org/r/66119/diff/5/
Changes: https://reviews.apache.org/r/66119/diff/4-5/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/
-----------------------------------------------------------
(Updated March 21, 2018, 11:35 a.m.)
Review request for mesos and Greg Mann.
Changes
-------
Thanks for the review! Patch updated.
Repository: mesos
Description
-------
Added a mock sandbox garbage collector.
Diffs (updated)
-----
src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
Diff: https://reviews.apache.org/r/66119/diff/3/
Changes: https://reviews.apache.org/r/66119/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 66119: Added a mock sandbox garbage collector.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66119/#review199604
-----------------------------------------------------------
src/tests/mesos.cpp
Lines 687-688 (patched)
<https://reviews.apache.org/r/66119/#comment279929>
Do your tests rely on this default behavior? If not, we can remove it.
- Greg Mann
On March 16, 2018, 6:17 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66119/
> -----------------------------------------------------------
>
> (Updated March 16, 2018, 6:17 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a mock sandbox garbage collector.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp 2c3d0c9350bbbbcd2223ff20c0797d1849d38c19
> src/tests/mesos.cpp d82963195573dd9ed7d12a7708f64a236b28cdf1
>
>
> Diff: https://reviews.apache.org/r/66119/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>