You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Erik Godding Boye (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 09:57:38 UTC

[jira] [Created] (WICKET-4452) Page id unique across sessions (or even globally unique)

Page id unique across sessions (or even globally unique)
--------------------------------------------------------

                 Key: WICKET-4452
                 URL: https://issues.apache.org/jira/browse/WICKET-4452
             Project: Wicket
          Issue Type: Improvement
            Reporter: Erik Godding Boye


The page id (Page#numericId) is an integer originating from a session scoped "sequence" (Session#pageId). This makes the page id only unique to the session.
I think there are rationales for making the page id unique across sessions, or even globally unique (using UUID i.e.).

One potential use case is described in the (closed) issue WICKET-3554.

Without breaking the API backwards compatibility, some uniqueness may be introduced by using the Random class to generate pageIds. 
But this can be greatly improved by changing the type of pageId from int to String, and use the UUID class to generate globally unique identifiers, but that will break the API compatibility....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4452) Page id unique across sessions (or even globally unique)

Posted by "Erik Godding Boye (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230072#comment-13230072 ] 

Erik Godding Boye commented on WICKET-4452:
-------------------------------------------

Sorry, I overlooked the extensive use of pageId - I see the point of ugly URLs.

What I would like see is some kind of session scoped page store where (non-expired pages) are referable with an unique identifier (ideally globally unique). I understand that the page id cannot be used in this context, and I guess I'll just have to create my own (session scoped, weak referenced) page map to achieve this.

This issue may be closed.
                
> Page id unique across sessions (or even globally unique)
> --------------------------------------------------------
>
>                 Key: WICKET-4452
>                 URL: https://issues.apache.org/jira/browse/WICKET-4452
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Erik Godding Boye
>
> The page id (Page#numericId) is an integer originating from a session scoped "sequence" (Session#pageId). This makes the page id only unique to the session.
> I think there are rationales for making the page id unique across sessions, or even globally unique (using UUID i.e.).
> One potential use case is described in the (closed) issue WICKET-3554.
> Without breaking the API backwards compatibility, some uniqueness may be introduced by using the Random class to generate pageIds. 
> But this can be greatly improved by changing the type of pageId from int to String, and use the UUID class to generate globally unique identifiers, but that will break the API compatibility....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-4452) Page id unique across sessions (or even globally unique)

Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4452.
-------------------------------------

    Resolution: Not A Problem

Hint: the default page store uses sessionId+pageId as a key to find pageAsBytes.
                
> Page id unique across sessions (or even globally unique)
> --------------------------------------------------------
>
>                 Key: WICKET-4452
>                 URL: https://issues.apache.org/jira/browse/WICKET-4452
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Erik Godding Boye
>
> The page id (Page#numericId) is an integer originating from a session scoped "sequence" (Session#pageId). This makes the page id only unique to the session.
> I think there are rationales for making the page id unique across sessions, or even globally unique (using UUID i.e.).
> One potential use case is described in the (closed) issue WICKET-3554.
> Without breaking the API backwards compatibility, some uniqueness may be introduced by using the Random class to generate pageIds. 
> But this can be greatly improved by changing the type of pageId from int to String, and use the UUID class to generate globally unique identifiers, but that will break the API compatibility....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4452) Page id unique across sessions (or even globally unique)

Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229998#comment-13229998 ] 

Martin Grigorov commented on WICKET-4452:
-----------------------------------------

Hi,

What will that bring for you ? I don't see any benefit here.
People are complaining about the "ugly" page id in the url even now. With UUID it will be even more ugly. With Random it will be just broken because you may see someone else's session.
Can you explain what is the current problem ?
I'll answer you separately in WICKET-3554.
                
> Page id unique across sessions (or even globally unique)
> --------------------------------------------------------
>
>                 Key: WICKET-4452
>                 URL: https://issues.apache.org/jira/browse/WICKET-4452
>             Project: Wicket
>          Issue Type: Improvement
>            Reporter: Erik Godding Boye
>
> The page id (Page#numericId) is an integer originating from a session scoped "sequence" (Session#pageId). This makes the page id only unique to the session.
> I think there are rationales for making the page id unique across sessions, or even globally unique (using UUID i.e.).
> One potential use case is described in the (closed) issue WICKET-3554.
> Without breaking the API backwards compatibility, some uniqueness may be introduced by using the Random class to generate pageIds. 
> But this can be greatly improved by changing the type of pageId from int to String, and use the UUID class to generate globally unique identifiers, but that will break the API compatibility....

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira