You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/30 10:19:59 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26321: [SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils

dongjoon-hyun commented on a change in pull request #26321: [SPARK-29653][SQL] Fix MICROS_PER_MONTH in IntervalUtils
URL: https://github.com/apache/spark/pull/26321#discussion_r340531157
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/results/date_part.sql.out
 ##########
 @@ -857,7 +857,7 @@ select date_part('epoch', c) from t2
 -- !query 106 schema
 struct<date_part('epoch', t2.`c`):decimal(18,6)>
 -- !query 106 output
-31873892788.332003
+31897220765.004003
 
 Review comment:
   Thanks, @yaooqinn . This looks enough. Shall we revert the changes on `IntervalUtilsSuite.scala`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org