[GitHub] [iceberg] danielcweeks commented on a diff in pull request #4894: Core: Add REST catalog session timeout

[GitBox <gi...@apache.org>]

danielcweeks commented on code in PR #4894:
URL: https://github.com/apache/iceberg/pull/4894#discussion_r884314519


##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Properties.java:
##########
@@ -37,8 +37,8 @@ private OAuth2Properties() {
    * Interval in milliseconds to wait before attempting to exchange the configured catalog Bearer token.
    * By default, token exchange will be attempted after 1 hour.
    */
-  public static final String EXCHANGE_TOKEN_MS = "exchange-token-in-ms";
-  public static final long EXCHANGE_TOKEN_MS_DEFAULT = 3_600_000; // 1 hour
+  public static final String TOKEN_EXPIRES_IN_MS = "token-expires-in-ms";

Review Comment:
   OAuth spec has this as seconds.  Should we just use the unit from the spec?  I'm not sure milliseconds add much value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org