You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/16 00:46:48 UTC

[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5046: AWS: support configure region

amogh-jahagirdar commented on code in PR #5046:
URL: https://github.com/apache/iceberg/pull/5046#discussion_r922590682


##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -140,17 +155,22 @@ public void initialize(Map<String, String> properties) {
           AwsProperties.S3_USE_ARN_REGION_ENABLED,
           AwsProperties.S3_USE_ARN_REGION_ENABLED_DEFAULT
       );
-
       ValidationException.check(
           (s3AccessKeyId == null) == (s3SecretAccessKey == null),
-          "S3 client access key ID and secret access key must be set at the same time");
+          "S3 client access key ID and secret access key must be set at the same time"
+      );
+
+      this.kmsRegion = properties.get(AwsProperties.KMS_REGION);
+      this.glueRegion = properties.get(AwsProperties.GLUE_REGION);
+      this.dynamoDbRegion = properties.get(AwsProperties.DYNAMODB_REGION);
       this.dynamoDbEndpoint = properties.get(AwsProperties.DYNAMODB_ENDPOINT);
+

Review Comment:
   Nit: unnecessary new line



##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -539,6 +563,7 @@ public void setGlueCatalogId(String id) {
   public boolean glueCatalogSkipArchive() {
     return glueCatalogSkipArchive;
   }
+

Review Comment:
   Nit: Unnecessary new line 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org