[GitHub] [spark] rdblue commented on a change in pull request #24686: [SPARK-27813][SQL] DataSourceV2: Add DropTable logical operation

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #24686: [SPARK-27813][SQL] DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r287051454
 
 

 ##########
 File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/IdentifierImpl.java
 ##########
 @@ -49,6 +49,11 @@ public String name() {
     return name;
   }
 
+  @Override
+  public String toString() {
+    return Arrays.toString(namespace) + " " + name;
 
 Review comment:
   I think this should produce the quoted identifier that can be parsed, like what is produced by `CatalogV2Implicits.IdentifierHelper`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org