You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by GitBox <gi...@apache.org> on 2020/09/24 04:33:04 UTC

[GitHub] [incubator-toree] Key2Love opened a new pull request #191: Update README.md

Key2Love opened a new pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191


   I think this should be consistent with the installation command on the official website, because not everyone knows where spark is installed. Modified this block, we can remind users to specify the spark path
   ![image](https://user-images.githubusercontent.com/33833308/94101181-f857ae00-fe61-11ea-873b-86fbacf57650.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] lresende commented on a change in pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
lresende commented on a change in pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191#discussion_r494423987



##########
File path: README.md
##########
@@ -101,8 +101,8 @@ Dev snapshots of Toree are located at https://dist.apache.org/repos/dist/dev/inc
 of those packages, you can use the following:
 
 ```
-pip install <PIP_RELEASE_URL>
-jupyter toree install
+pip install --upgrade toree
+jupyter toree install --spark_home=/usr/local/bin/apache-spark/
 ```
 
 where `PIP_RELEASE_URL` is one of the `pip` packages. For example:

Review comment:
       this paragraph will now become obsolete. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] Key2Love closed pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
Key2Love closed pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] lresende commented on a change in pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
lresende commented on a change in pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191#discussion_r495676454



##########
File path: README.md
##########
@@ -101,8 +101,8 @@ Dev snapshots of Toree are located at https://dist.apache.org/repos/dist/dev/inc
 of those packages, you can use the following:
 
 ```
-pip install <PIP_RELEASE_URL>
-jupyter toree install
+pip install --upgrade toree
+jupyter toree install --spark_home=/usr/local/bin/apache-spark/
 ```
 
 where `PIP_RELEASE_URL` is one of the `pip` packages. For example:

Review comment:
       @Key2Love I am not disagreeing with your pr, per contrary, it's good, but with the change, we should remove the lines below as they were applying to old contents, no? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] lresende commented on a change in pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
lresende commented on a change in pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191#discussion_r494423987



##########
File path: README.md
##########
@@ -101,8 +101,8 @@ Dev snapshots of Toree are located at https://dist.apache.org/repos/dist/dev/inc
 of those packages, you can use the following:
 
 ```
-pip install <PIP_RELEASE_URL>
-jupyter toree install
+pip install --upgrade toree
+jupyter toree install --spark_home=/usr/local/bin/apache-spark/
 ```
 
 where `PIP_RELEASE_URL` is one of the `pip` packages. For example:

Review comment:
       this paragraph will now become obsolete. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] lresende merged pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
lresende merged pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] Key2Love commented on a change in pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
Key2Love commented on a change in pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191#discussion_r494730993



##########
File path: README.md
##########
@@ -101,8 +101,8 @@ Dev snapshots of Toree are located at https://dist.apache.org/repos/dist/dev/inc
 of those packages, you can use the following:
 
 ```
-pip install <PIP_RELEASE_URL>
-jupyter toree install
+pip install --upgrade toree
+jupyter toree install --spark_home=/usr/local/bin/apache-spark/
 ```
 
 where `PIP_RELEASE_URL` is one of the `pip` packages. For example:

Review comment:
       ok,but when i enter the command "pip install <PIP_RELEASE_URL> 
   jupyter toree install", jupyter console reports "spark not found" cause jupyter sets spark_home as default,actually i didn't install spark at that path. I think it is a little bit ambiguous




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-toree] Key2Love commented on a change in pull request #191: Update README.md

Posted by GitBox <gi...@apache.org>.
Key2Love commented on a change in pull request #191:
URL: https://github.com/apache/incubator-toree/pull/191#discussion_r494730993



##########
File path: README.md
##########
@@ -101,8 +101,8 @@ Dev snapshots of Toree are located at https://dist.apache.org/repos/dist/dev/inc
 of those packages, you can use the following:
 
 ```
-pip install <PIP_RELEASE_URL>
-jupyter toree install
+pip install --upgrade toree
+jupyter toree install --spark_home=/usr/local/bin/apache-spark/
 ```
 
 where `PIP_RELEASE_URL` is one of the `pip` packages. For example:

Review comment:
       ok,but when i enter the command "pip install <PIP_RELEASE_URL> 
   jupyter toree install", jupyter console reports "spark not found" cause jupyter sets spark_home as default,actually i didn't install spark at that path. I think it is a little bit ambiguous




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org