You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by amaral7 <gi...@git.apache.org> on 2016/09/15 17:28:15 UTC
[GitHub] commons-lang pull request #191: ToStringExcludeNullValue
GitHub user amaral7 opened a pull request:
https://github.com/apache/commons-lang/pull/191
ToStringExcludeNullValue
I added an annotation to exclude a field from toString when the value is null.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amaral7/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #191
----
commit 42005b30320cfec70e4fd02321ca5d59e0d3af5c
Author: Gabriel Amaral <ga...@gmail.com>
Date: 2016-09-15T16:54:43Z
Add annotation ToStringExcludeNullValue
commit 9f6acd29875b159f7f893671f0cf8c3934deb03d
Author: Gabriel Amaral <ga...@gmail.com>
Date: 2016-09-15T17:18:20Z
Merge remote-tracking branch 'upstream/master'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by amaral7 <gi...@git.apache.org>.
Github user amaral7 commented on the issue:
https://github.com/apache/commons-lang/pull/191
@britter when I made the changes, I was thinking to cover the largest number of possible cases, and for this reason I implemented this configuration per field that would cover even who wants the general behavior for all fields, but more painful. I think there may be cases that need this behavior per field, but I know that most cases would be more comprehensive, for this reason have made the changes. And that wasn�t so painful to me ;).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/191
[](https://coveralls.io/builds/7906000)
Coverage increased (+0.01%) to 93.587% when pulling **9f6acd29875b159f7f893671f0cf8c3934deb03d on amaral7:master** into **9c506279188a90dbbe124386cc52016682d17b5c on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/191
[](https://coveralls.io/builds/8050364)
Coverage increased (+0.002%) to 93.547% when pulling **935149511e8e4f4fce5d4140ff68fd3196296436 on amaral7:master** into **a04151819758fceb7f0cb855d279c9d46b2e9851 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/191
Support for excluding `null` values was added in https://github.com/apache/commons-lang/commit/8147cc5b3de5fa7a3a3e8116355efa44367dc3c5
@gabriel-amaral Thanks for the pull request and sorry that it was not merged. Can you please close it? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #191: ToStringExcludeNullValue
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the issue:
https://github.com/apache/commons-lang/pull/191
@amaral7 do you really want to configure this on a per field basis or would it be enough to add a configuration option to `ToStringBuilder` to configure the general behavior for all fields?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #191: ToStringExcludeNullValue
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/191
[](https://coveralls.io/builds/8049954)
Coverage decreased (-0.01%) to 93.533% when pulling **9af3014b5188aa8c76b41e8dda0213eb7a542cb2 on amaral7:master** into **a04151819758fceb7f0cb855d279c9d46b2e9851 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---