[GitHub] [accumulo] dlmarion commented on a diff in pull request #3653: Allow tests to override TGW interval, add Compactor job wait property

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on code in PR #3653:
URL: https://github.com/apache/accumulo/pull/3653#discussion_r1273842146


##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -426,8 +426,9 @@ protected void updateCompactionCompleted(TExternalCompactionJob job, TCompaction
    * @throws RetriesExceededException thrown when retries have been exceeded
    */
   protected TExternalCompactionJob getNextJob(Supplier<UUID> uuid) throws RetriesExceededException {
+    final long checkWaitTime = getConfiguration().getTimeInMillis(Property.COMPACTOR_JOB_WAIT_TIME);
     RetryableThriftCall<TExternalCompactionJob> nextJobThriftCall =
-        new RetryableThriftCall<>(1000, RetryableThriftCall.MAX_WAIT_TIME, 0, () -> {
+        new RetryableThriftCall<>(checkWaitTime, checkWaitTime, 0, () -> {

Review Comment:
   So, I added a max wait time property, but I left the starting wait time property instead of going back to a hard-coded 1s.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org