You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/15 17:46:17 UTC

[GitHub] [spark] c21 commented on a change in pull request #32911: [SPARK-35760][SQL] Fix the max rows check for broadcast exchange

c21 commented on a change in pull request #32911:
URL: https://github.com/apache/spark/pull/32911#discussion_r652018211



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -105,6 +106,17 @@ case class BroadcastExchangeExec(
   @transient
   private val timeout: Long = conf.broadcastTimeout
 
+  @transient
+  private lazy val maxBroadcastRows = mode match {
+    case HashedRelationBroadcastMode(key, _)
+      if !(key.length == 1 && key.head.dataType == LongType) =>

Review comment:
       @dongjoon-hyun - sure, added.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org