[kudu-CR] log: Mark allocation finished even if allocation had an error

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3234

to look at the new patch set (#3).

Change subject: log: Mark allocation finished even if allocation had an error
......................................................................

log: Mark allocation finished even if allocation had an error

This fixes two bugs:

1. If a disk preallocation fails we will enter a "stuck" state where we
   cannot preallocate a new segment. Errors to allocate or append should
   be propagated up.

2. If anything fails in DoAppend() we will attempt to delete
   ReplicateMsg member objects in LogEntryPB twice, resulting in a
   segfault.

Added a test that crashes without the code changes in log.cc

Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
---
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/consensus/raft_consensus.cc
8 files changed, 48 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3234/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If22bf946a42d0ec32c35164acd9e6e6cef18dcc3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>