You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/23 15:17:32 UTC
[GitHub] [skywalking] wu-sheng opened a new issue #7543: [Eyes] Absolute path resolution bug in git ignore and check escape
wu-sheng opened a new issue #7543:
URL: https://github.com/apache/skywalking/issues/7543
> 7. The paths-ignore are the path list that will be ignored by license-eye. By default, .git and the content in .gitignore will be inflated into the paths-ignore list.
I found this at doc, https://github.com/apache/skywalking-eyes#configurations.
So, according to doc, this is a bug.
But I would be very surprised about this folder includes actually managed files. @spacewander I think this feature was designed to skip local(never submitted files).
___
@kezhenxu94 @fgksgf I would treat APISIX's use case as a very specific leak case for header check. It is better to provide a `local-mode`(or any better name) to accept git ignore file.
Once you have a resolution, you could create a bug/feature issue with good explanations about how we should fix this. Or we could continue the discussion here.
_Originally posted by @wu-sheng in https://github.com/apache/skywalking/discussions/7542#discussioncomment-1222951_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7543: [Eyes] Absolute path resolution bug in git ignore and check escape
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7543:
URL: https://github.com/apache/skywalking/issues/7543#issuecomment-903868245
This discussion based issue includes a bug and a feature request.
@kezhenxu94 @fgksgf Please make the final decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #7543: [Eyes] Absolute path resolution bug in git ignore and check escape
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7543:
URL: https://github.com/apache/skywalking/issues/7543#issuecomment-903868245
This discussion based issue includes a bug and a feature request.
@kezhenxu94 @fgksgf Please make the final decision.(Decision doesn't mean you have to fix by yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #7543: [Eyes] Absolute path resolution bug in git ignore and check escape
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7543:
URL: https://github.com/apache/skywalking/issues/7543#issuecomment-903868245
This discussion based issue includes a bug and a feature request.
@kezhenxu94 @fgksgf Please make the final decision.(Decision doesn't mean they have to fix by yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7543: [Eyes] Absolute path resolution bug in git ignore and check escape
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7543:
URL: https://github.com/apache/skywalking/issues/7543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org