You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2023/01/16 22:56:24 UTC
[GitHub] [netbeans] junichi11 opened a new pull request, #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
junichi11 opened a new pull request, #5302:
URL: https://github.com/apache/netbeans/pull/5302
## PHP 8.2 Support: Constants in Traits (Part 1)
- https://wiki.php.net/rfc/constants_in_traits
- Fix the grammar file
- Fix `PHP82UnhandledError`
- Add/Fix unit tests for the parser, the lexer, and `IncorrectEnumHintError`
PHP 8.2

PHP 8.1

## PHP 8.2 Support: Constants in Traits (Part 2)
- https://wiki.php.net/rfc/constants_in_traits
- Add trait constants to the index
- Fix the navigator
- Add unit tests for the index and the navigator
## PHP 8.2 Support: Constants in Traits (Part 3)
- https://wiki.php.net/rfc/constants_in_traits
- Fix coloring for trait constants
- Add unit tests
## PHP 8.2 Support: Constants in Traits (Part 4)
- https://wiki.php.net/rfc/constants_in_traits
- Fix the code completion feature
- Add unit tests
## PHP 8.2 Support: Constants in Traits (Part 5)
- https://wiki.php.net/rfc/constants_in_traits
- Fix the mark occurrences and the go to declaration
- Add unit tests
## PHP 8.2 Support: Disjunctive Normal Form Types (Part 1)
- https://wiki.php.net/rfc/dnf_types
- Fix the grammar file, `PHP82UnhandledError`, and `UnusableTypeHintError`
- Add/Fix unit tests for the parser
PHP 8.2

PHP 8.1

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
Posted by GitBox <gi...@apache.org>.
junichi11 commented on PR #5302:
URL: https://github.com/apache/netbeans/pull/5302#issuecomment-1384759825
@tmysik Could you please have a look at this if you have time today?
After that, let's merge #5300.
I thought we can merge PR for NB17 until tomorrow, but it is until today.
I'm so sorry to rush you...
If you are busy, let's merge #5300 without merging this :) (I'll change to NB18)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
Posted by GitBox <gi...@apache.org>.
junichi11 commented on PR #5302:
URL: https://github.com/apache/netbeans/pull/5302#issuecomment-1385153943
Thank a lot for your review and your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik merged pull request #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
Posted by GitBox <gi...@apache.org>.
tmysik merged PR #5302:
URL: https://github.com/apache/netbeans/pull/5302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a diff in pull request #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
Posted by GitBox <gi...@apache.org>.
tmysik commented on code in PR #5302:
URL: https://github.com/apache/netbeans/pull/5302#discussion_r1071952500
##########
php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java:
##########
@@ -826,4 +826,15 @@ public static String removeNullableTypePrefix(String typeName) {
public static OffsetRange getOffsetRagne(@NonNull ASTNode node) {
return new OffsetRange(node.getStartOffset(), node.getEndOffset());
}
+
+ public static boolean isDnfType(UnionType unionType) {
Review Comment:
```suggestion
public static boolean isDnfType(@Nullable UnionType unionType) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a diff in pull request #5302: PHP 8.2 Support: Constants in Traits and Disjunctive Normal Form Types
Posted by GitBox <gi...@apache.org>.
junichi11 commented on code in PR #5302:
URL: https://github.com/apache/netbeans/pull/5302#discussion_r1072018752
##########
php/php.editor/src/org/netbeans/modules/php/editor/CodeUtils.java:
##########
@@ -826,4 +826,15 @@ public static String removeNullableTypePrefix(String typeName) {
public static OffsetRange getOffsetRagne(@NonNull ASTNode node) {
return new OffsetRange(node.getStartOffset(), node.getEndOffset());
}
+
+ public static boolean isDnfType(UnionType unionType) {
Review Comment:
Thanks! Will fix it next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists