[jira] [Commented] (REEF-1281) REEF.NET uses RuntimeClock instead of IClock

["Anupam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234399#comment-15234399 ] 

Anupam commented on REEF-1281:
------------------------------

Removing the usage from {{Evaluator}} would need a breaking change in {{IClock}} interface as far as I can tell. Not sure why these things were made public in {{RuntimeClock}} and not added to {{IClock}}. Anyone has insight?

> REEF.NET uses RuntimeClock instead of IClock
> --------------------------------------------
>
>                 Key: REEF-1281
>                 URL: https://issues.apache.org/jira/browse/REEF-1281
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET
>            Reporter: Markus Weimer
>            Assignee: Anupam
>            Priority: Minor
>
> The REEF.NET code is currently using the {{RuntimeClock}} type directly instead of {{IClock}}. This defeats the purpose of having the interface in the first place: When writing tests for e.g. timeouts, it is very convenient to supply a clock that runs faster than real time.
> We should refactor all uses of {{RuntimeClock}} in the code base and use the interface {{IClock}} wherever possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)