[GitHub] trafficserver pull request: [TS-4160] Reset the txn request/respon...

[bgaff <gi...@git.apache.org>]

Github user bgaff commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/443#discussion_r51376076
  
    --- Diff: lib/atscppapi/src/utils_internal.cc ---
    @@ -61,19 +73,14 @@ handleTransactionEvents(TSCont cont, TSEvent event, void *edata)
         (void)TSHttpTxnClientReqGet(static_cast<TSHttpTxn>(transaction.getAtsHandle()), &hdr_buf, &hdr_loc);
         break;
       case TS_EVENT_HTTP_SEND_REQUEST_HDR:
    -    utils::internal::initTransactionServerRequest(transaction);
    -    break;
       case TS_EVENT_HTTP_READ_RESPONSE_HDR:
    -    utils::internal::initTransactionServerResponse(transaction);
    -    break;
       case TS_EVENT_HTTP_SEND_RESPONSE_HDR:
    -    utils::internal::initTransactionClientResponse(transaction);
    -    break;
       case TS_EVENT_HTTP_READ_CACHE_HDR:
    -    utils::internal::initTransactionCachedRequest(transaction);
    -    utils::internal::initTransactionCachedResponse(transaction);
    +    // the buffer handles may be destroyed in the core during redirect follow
    +    initTransactionHandles(transaction);
    --- End diff --
    
    I'm not seeing why you want to do them all upfront and repeat in each hook?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---