[jira] [Commented] (BOOKKEEPER-660) Logs too noisy on NIOServerFactory when client drops a connection

["Flavio Junqueira (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730825#comment-13730825 ] 

Flavio Junqueira commented on BOOKKEEPER-660:
---------------------------------------------

The patch looks good to me, the only small comment I have is that the severity level should be perhaps warn. But, if you feel strongly about being info, I won't insist.


                
> Logs too noisy on NIOServerFactory when client drops a connection
> -----------------------------------------------------------------
>
>                 Key: BOOKKEEPER-660
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-660
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 4.2.0
>            Reporter: Ivan Kelly
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.2.2
>
>         Attachments: BOOKKEEPER-660.diff
>
>
> When a client drops a connection, the server throws an exception. It should only log at info level and close the socket.
> {code}
>     if (k.isReadable()) {
>         int rc = sock.read(incomingBuffer);
>         if (rc < 0) {
>             throw new IOException("Read error");
>         }
>         if (incomingBuffer.remaining() == 0) {
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira