[GitHub] [kafka] rajinisivaram commented on a change in pull request #10267: KAFKA-12427: Don't update connection idle time for muted connections

[GitBox <gi...@apache.org>]

rajinisivaram commented on a change in pull request #10267:
URL: https://github.com/apache/kafka/pull/10267#discussion_r588308473



##########
File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java
##########
@@ -517,7 +517,7 @@ void pollSelectionKeys(Set<SelectionKey> selectionKeys,
 
             // register all per-connection metrics at once
             sensors.maybeRegisterConnectionMetrics(nodeId);
-            if (idleExpiryManager != null)
+            if (idleExpiryManager != null && !explicitlyMutedChannels.contains(channel))

Review comment:
       This is limiting the times when we perform the update. For example when sending response, the channel is active, but explicitly muted. Don't think we want to skip update in this case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org