[GitHub] [spark] cloud-fan commented on a diff in pull request #40103: [SPARK-42516][SQL] Always capture the session time zone config while creating views

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #40103:
URL: https://github.com/apache/spark/pull/40103#discussion_r1113948302


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala:
##########
@@ -398,8 +398,13 @@ object ViewHelper extends SQLConfHelper with Logging {
     val modifiedConfs = conf.getAllConfs.filter { case (k, _) =>
       conf.isModifiable(k) && shouldCaptureConfig(k)
     }
+    // Get the default value of always captured config if it is not set

Review Comment:
   let's add more comments:
   ```
   // Some configs have dynamic default values, such as SESSION_LOCAL_TIMEZONE whose
   // default value relies on the JVM system timezone. We need to always capture them to
   // to make sure we apply the same configs when reading the view.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org